Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in the Project Settings type dropdown #33076

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Fix off-by-one error in the Project Settings type dropdown #33076

merged 1 commit into from
Oct 26, 2019

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 25, 2019 •
edited
Loading

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

Follow-up to #32624.

We also don't need to set the item ID explicitly (it has no impact on the resulting OptionButton).

This closes #33075.

@Calinou Calinou force-pushed the project-settings-fix-type-dropdown branch from 5d7b658 to 929d8dd Compare October 25, 2019 21:58
@Chaosus Chaosus added this to the 3.2 milestone Oct 26, 2019
@akien-mga akien-mga merged commit 8cef880 into godotengine:master Oct 26, 2019
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the project-settings-fix-type-dropdown branch January 27, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Adding a custom project setting type is off by 1.
3 participants
@Calinou @akien-mga @Chaosus