Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TreeItem.get_button_tooltip(column, idx). #32369

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

ndarilek
Copy link
Contributor

@ndarilek ndarilek commented Sep 26, 2019

When added to TreeItem, buttons are given tooltips. When returned via get_button(...), however, the button is a Texture and the tooltip information isn't included.

For accessibility purposes, it is useful to have access to the tooltip text. As such, we can retrieve a button's tooltip to use as a button label.

My accessibility addon needs this to allow keyboard control over buttons in Tree columns. Specifically, without it, I can't add keys/buttons to actions.

Related to #14011.

When added to `TreeItem`, buttons are given tooltips. When returned via `get_button(...)`, however, the button is a `Texture` and the tooltip information isn't included.

For accessibility purposes, it is useful to have access to the tooltip text. As such, we can retrieve a button's tooltip to use as a button label.
@ndarilek ndarilek requested a review from a team as a code owner September 26, 2019 15:43
@YeldhamDev YeldhamDev changed the title #14011: Implement TreeItem.get_button_tooltip(column, idx). Implement TreeItem.get_button_tooltip(column, idx). Sep 26, 2019
@akien-mga akien-mga added this to the 3.2 milestone Sep 27, 2019
@akien-mga akien-mga merged commit fd0ad20 into godotengine:master Sep 27, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants