Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Test project exporting/script running in the headless editor #31013

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 1, 2019

This makes sure regressions in the editor CLI functionality are caught early on.

Suggestions for making the test process cleaner or more complete are welcome 🙂

See #17408.

@akien-mga
Copy link
Member

I wouldn't include test projects in this repo, they should be in a dedicated Git repo which can be cloned during CI.

@Calinou
Copy link
Member Author

Calinou commented Aug 1, 2019

@akien-mga Should we create a dedicated repository with the test project? We could reuse godot-tests, but then, we'd be cloning some data we don't use. (It's not that large right now, so it might not be an issue after all.)

@akien-mga
Copy link
Member

I think we can reuse godot-tests for now.

@Calinou Calinou force-pushed the travis-test-headless-editor branch from dd7e888 to a365e04 Compare August 8, 2019 13:36
@Calinou Calinou force-pushed the travis-test-headless-editor branch from a365e04 to e2eb3f7 Compare August 19, 2019 11:33
@Calinou Calinou force-pushed the travis-test-headless-editor branch from e2eb3f7 to 5efd436 Compare August 20, 2019 15:36
@akien-mga akien-mga merged commit 8d5b969 into godotengine:master Aug 20, 2019
@akien-mga
Copy link
Member

Thanks!

@bruvzg
Copy link
Member

bruvzg commented Aug 26, 2019

There's something wrong with return values, seems like it's returning 0 for failed jobs with TEST_PROJECT disabled.

For example, I have rebased PR, it gone badly and build failed for all platforms, but Travis registered all except "Linux headless editor" as passed.

Build log: https://travis-ci.org/godotengine/godot/builds/576809375

4 errors generated.

scons: *** [editor/project_manager.osx.tools.64.o] Error 1

scons: building terminated because of errors.

The command "if [ "$STATIC_CHECKS" = "yes" ]; then sh ./misc/travis/clang-format.sh; else scons -j2 CC=$CC CXX=$CXX platform=$PLATFORM tools=$TOOLS target=$TARGET $OPTIONS $EXTRA_ARGS;

if [ "$TEST_PROJECT" = "yes" ]; then git clone --depth 1 "https://github.com/godotengine/godot-tests.git"; sed -i "s:custom_template/release=\"\":custom_template/release=\"$(readlink -e bin/godot_server.x11.opt.tools.64)\":" godot-tests/tests/project_export/export_presets.cfg; godot-tests/tests/project_export/test_project.sh "bin/godot_server.x11.opt.tools.64"; fi fi" exited with 0.

...

Done. Your build exited with 0.

akien-mga added a commit to akien-mga/godot that referenced this pull request Aug 27, 2019
Seems to be a 5 year old bug that upstream doesn't care about.
travis-ci/travis-ci#1066
@akien-mga
Copy link
Member

@bruvzg Should be fixed by #31714.

akien-mga added a commit that referenced this pull request Aug 27, 2019
Travis: Fix builds wrongly reporting success after #31013
pchasco pushed a commit to pchasco/godot that referenced this pull request Oct 23, 2019
Seems to be a 5 year old bug that upstream doesn't care about.
travis-ci/travis-ci#1066
@Calinou Calinou deleted the travis-test-headless-editor branch January 27, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants