Add buttons to remove keys\items from dictionaries\arrays.

[nhold]

This PR adds a 'remove' button for array items and dictionary items.

Fixes #23058.

[nhold]

PoolXArrays now have deletes and no longer crash:

[akien-mga]

Looks good overall, can be merged once pending comments are addressed.

[akien-mga]

There seems to be some trailing whitespace according to Travis logs.

[hilfazer]

This change bloats Inspector horizontally and the goal is to have it very horizontally compact.

Is there an option to hide this button?

(above screenshot is actually from Debug window since Inspector has a bug and can't show 3rd level of nesting when dictionary is involved)

[akien-mga]

Right, that was also my concern. I don't think it should be made optional, but we should find a different way to provide this feature without bloating the UI.

One option would be to change the Edit button to a drop down menu with Edit and Delete options.

[hilfazer]

One button with 2 options is a cool idea.
I'd be even cooler if this button had less width than current Edit. Perhaps button from dock windows, with 3 vertical dots, could be used? It's quite thin.

[nhold]

The horizontal bloat for nested arrays\dictionaries needs to be solved in a smarter way but I can change the edit button to an 'options' button with edit and delete options.

[akien-mga]

The horizontal bloat for nested arrays\dictionaries needs to be solved in a smarter way but I can change the edit button to an 'options' button with edit and delete options.

I agree with both statements, this will need to be reworked eventually, but in the meantime having an Options button instead of the current Edit one seems good.

[nhold]

Some Notes:

• I manually fixed the merge conflict (RID change).
• Array now copies dictionary style (Edit Type->Remove Item) if it's untyped. If it's typed it's still the trash button as there is no reason to show a menu for one option.
• Removed the dictionary addition, it already had a remove item anyway.
• I ran the clang formatter through Visual Studio, it seemed to alter parts in the file I hadn't touched please advise if I should revert these lines.

[akien-mga]

I ran the clang formatter through Visual Studio, it seemed to alter parts in the file I hadn't touched please advise if I should revert these lines.

The changes removing new lines after { are wrong indeed, our style guide allows those so far and up until version 8.0 at least clang-format would not remove them. What version do you have?

[akien-mga]

The changes removing new lines after { are wrong indeed, our style guide allows those so far and up until version 8.0 at least clang-format would not remove them. What version do you have?

For the reference, the option that controls this is KeepEmptyLinesAtTheStartOfBlocks, which should default to true in clang-format 8.0 or earlier (so we don't override its default value for now). If you have a newer version (from SVN) and they decided to change the default, that could explain the changes you got.

[nhold]

I am not certain what version of clang-format visual studio uses. I used a custom install and it worked fine. Hopefully this is now satisfactory.

[akien-mga]

Thanks!