Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow changing array element types, when using hint (inspector fix) #24909

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Disallow changing array element types, when using hint (inspector fix) #24909

merged 1 commit into from
Jan 15, 2019

Conversation

xDGameStudios
Copy link
Contributor

@xDGameStudios xDGameStudios commented Jan 11, 2019

when an Array defined within the export keyword is given a subtype...

captura de ecra 2019-01-11 as 13 36 26

the "change type" (pencil) icon doesn't get drawn to avoid/disallow changing types of elements:

captura de ecra 2019-01-11 as 13 36 38

it's a simple fix, closes #24900!

@willnationsdev
Copy link
Contributor

This should totally be a consideration for cherry-picking into 3.1.1. It'd make usability for array values so much better. XD

Copy link
Contributor

@bojidar-bg bojidar-bg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga modified the milestones: 3.2, 3.1 Jan 15, 2019
@akien-mga akien-mga merged commit fadaeb0 into godotengine:master Jan 15, 2019
@akien-mga
Copy link
Member

Thanks!

@xDGameStudios xDGameStudios deleted the array_static_types branch January 29, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array of specified type should not allow change type.
4 participants