Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault on editor close up #23273

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Oct 25, 2018

Fix segfault in #23215

@Chaosus Chaosus added this to the 3.1 milestone Oct 25, 2018
@groud
Copy link
Member

groud commented Oct 25, 2018

I think using NOTIFICATION_THEME_CHANGED made sense, but it probably needs a check before running _update_display_mode().
Could you try something like that ? :

if (is_in_tree()) {
 _update_display_mode(true).
} 

@Chaosus
Copy link
Member Author

Chaosus commented Oct 25, 2018

True, its works ! How I didnt guess it myself...

@groud
Copy link
Member

groud commented Oct 25, 2018

Awesome, thanks ! :)

@akien-mga akien-mga merged commit 7d296a6 into godotengine:master Oct 25, 2018
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants