Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display camera coordinates in the 3D viewport's information pane #21897

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 9, 2018

This adds a camera coordinates display to the 3D viewport's information pane. The coordinates displayed will be from the previewed camera if one is currently being previewed.

This could make it easier to navigate and adjust node positions/rotations in a 3D world.

Preview:

Preview

@ghost
Copy link

ghost commented Sep 10, 2018

Would be nice if there's a way to teleport to any coordinates. AFAIK there's no way except creating a Spatial node, moving it and following it.

@@ -200,6 +200,7 @@ class SpatialEditorViewport : public Control {
Control *surface;
Viewport *viewport;
Camera *camera;
Camera *current_camera;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why save it as a member if you only need it in _notification where you set it?

@akien-mga akien-mga added this to the 3.1 milestone Sep 10, 2018
@Calinou Calinou force-pushed the 3d-display-camera-coordinates branch from b7b7bdf to 621a545 Compare September 10, 2018 22:04
@Calinou
Copy link
Member Author

Calinou commented Sep 10, 2018

I updated the pull request, please check it again 🙂

@akien-mga
Copy link
Member

We discussed this on IRC with @reduz and @mhilbrunner and they don't see much use case for this additional information, while it adds quite a lot of text.

Can others chime in and say whether they'd have a use for this or not?

@Zireael07
Copy link
Contributor

This would make it easier to make large 3d levels, even without teleportation proposed.

@akien-mga
Copy link
Member

Not many arguments for or against this change, but it's not much code so I guess it doesn't hurt giving it a try.

@akien-mga akien-mga merged commit a3501c0 into godotengine:master Nov 2, 2018
@akien-mga
Copy link
Member

Eventually it could be more interesting if the contents of the panel could be customized so that users can select what properties they want to monitor.

@Calinou Calinou deleted the 3d-display-camera-coordinates branch January 27, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants