Always disable V-Sync in the editor to improve UI responsiveness #20916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project's V-Sync value is no longer used to control whether the editor should use V-Sync. Note that the graphics driver may still force V-Sync; in this case, this change will have no effect (it will be enabled as it was before).
|
Given the following, I doubt @reduz will agree :) |
|
no, turning off vsync is always a bad idea. Closing this. |
This was referenced May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project's V-Sync value is no longer used to control whether the editor should use V-Sync.
Note that the graphics driver may still force V-Sync; in this case, this change will have no effect (it will be enabled as it was before).
If editing a project with V-Sync enabled (which is the default) and your graphics driver doesn't force V-Sync, this should increase responsiveness since there is no longer an inherent 1-frame delay caused by V-Sync.
If the editor has to be continuously redrawn for any reason, the rendering will be capped at 100 FPS if the editor is set to Update Changes, which is the default option.