Tweak some help texts in the build system #19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 7, 2018
SConstruct
Outdated
| opts.Add('extra_suffix', "Custom extra suffix added to the base filename of all generated binary files", '') | ||
| opts.Add('unix_global_settings_path', "UNIX-specific path to system-wide settings. Currently only used for templates", '') | ||
| opts.Add('unix_global_settings_path', "UNIX-specific path to system-wide settings (currently only used for templates)", '') |
There was a problem hiding this comment.
Actually I removed this option a while ago, just forgot to remove it in SConscript.
akien-mga
approved these changes
Jun 7, 2018
This also removes `unix_global_settings_path` from SConstruct since it is no longer used.
Calinou
force-pushed
the
tweak-scons-help-texts
branch
from
1cb8fe0 to
d54b5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few typos, improves grammar and uses correct casing in all help texts. This also removes some bits of commented-out code.