Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move things into the title bars of Visual Script nodes. #18516

Merged

Conversation

PJB3005
Copy link
Contributor

@PJB3005 PJB3005 commented Apr 29, 2018

Previously, EVERY NODE would have a label of text on the row of the primary sequence nodes, which was in a lot of cases ugly and wasted vertical space. Also do we really need half in-code names in the title bars? Waste of space.

This is an attempt to make VS slightly nicer to use.

WiP.
@mhilbrunner mhilbrunner changed the title Move things into the title bars of Visual Script nodes. [WIP] Move things into the title bars of Visual Script nodes. Apr 30, 2018
@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 30, 2018

image

@PJB3005 PJB3005 changed the title [WIP] Move things into the title bars of Visual Script nodes. Move things into the title bars of Visual Script nodes. Apr 30, 2018
@akien-mga akien-mga added this to the 3.1 milestone May 1, 2018
@reduz
Copy link
Member

reduz commented May 7, 2018

This looks nice to me, code also seems fine.

@mhilbrunner mhilbrunner merged commit 2fca33a into godotengine:master May 26, 2018
@PJB3005 PJB3005 deleted the 18-04-30-visual-script-title-bars branch May 26, 2018 16:12
@akien-mga
Copy link
Member

Next time please squash commits together (or if the second commit made sense to keep separate, give it a meaningful name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants