Add inherited variables support for script debugger

[Geequlim]

Fix #18346

[reduz]

Seems very nice, fine to merge by me

[neikeq]

I don't get it. What is base.gd and script_base.gd? Which one is the base script?

[Zireael07]

script_base looks to be the base (see BASE_CONST at the bottom)

[neikeq]

And what is base.gd? 😄

[Zireael07]

Example of really poor naming 😆

[Geequlim]

@neikeq This class extends base.gd which extends script_base.gd :p

[neikeq]

So if I understand correctly, in the image above we see A (script with the extend_var field) which inherits B (base.gd) which inherits C (script_base.gd). Am I right?

If that were the case, I think script_base.gd should be nested inside base.gd, not placed after it. e.g.:

extend_var
V base.gd
    base_var
    V script_base.gd
        a
        b

instead of

extend_var
V base.gd
    base_var
V script_base.gd
    a
    b

and maybe the base class should be placed before the other members:

V base.gd
    V script_base.gd
        a
        b
    base_var
extend_var

folded by default, of course.

[vnen]

I don't think it needs to be nested. It's like the regular Inspector: the derived class is shown first then it goes to each the parent classes. Godot doesn't have multiple inheritance, so if you nest them it'll just create a line of nested sections, reducing horizontal space as well.

[Geequlim]

@neikeq Yes. Other debugger inspector like QtCreator use a nested tree instead of a list to show the base classes.

Why I didn't nested the base classes:

• As mentioned by @vnen that will take more horizontal space.
• We have to expand more sections to check the members of the top-level base class.

[neikeq]

After thinking about the Inspector example, I think it's fine this way.

[akien-mga]

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.