Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact positioning for the ItemList::get_tooltip method. #15258

Merged
merged 1 commit into from
May 8, 2018

Conversation

RyanStein
Copy link
Contributor

This is a potential resolution for #15241, which makes all ItemLists use the exact position flag on get_item_at_position() for use within get_tooltip(), solving any potential issue with widely inaccurate, technically "closest" items being returned.

Note that this affects all ItemLists, not just the FileSystemDock class which uses it. I imagine the ramifications of this are not too terrible, but it has to be said.

@akien-mga
Copy link
Member

Thanks a lot for your contribution!
We are now entering a strict release freeze for Godot 3.0 and will only consider major bug fixes. We won't merge new features and enhancements anymore until 3.0 is released.

Moving this PR to the 3.1 milestone, to be reviewed once the release freeze is lifted. It could eventually be cherry-picked for a future 3.0.1 maintenance release if it doesn't change the user-facing APIs and doesn't compromise the engine's stability.

@akien-mga akien-mga modified the milestones: 3.0, 3.1 Jan 4, 2018
@reduz reduz merged commit 47db64a into godotengine:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants