Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1: File path in save dialog automatically appended with correct extension if not manually added by the user. 2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. #1223

Merged
merged 3 commits into from
Jan 17, 2015

Conversation

NathanWarden
Copy link
Contributor

Both of these commits are based off of this thread in the Google mailing list:
https://groups.google.com/forum/#!topic/godot-engine/conGaOeeG8w


Commit 1:

Instead of showing the "Must use a valid extension." dialog, the item being saved will use the selected extension of the file types when the filter only contains one option extension.

For instance, when saving a scene file, selecting SCN will automatically add the extension if .scn is not in the file name already. If "All Recognized" is selected it will still show the "Must use a valid extension." dialog.

I think it might be good behavior to have this apply to something like the "All Recognized" as well and select the first option instead of the dialog. If you agree, let me know and I will add that functionality as well.


Commit 2:

Removed "bin" from the Linux export so that it will default to "All Files". This is due to myself and others experiencing an issue where several filemanagers such as Nautilus and LXDE will try and find a program to open the executable instead of just running it. If the build has no extension it works just fine. If the .bin extension is kept it will likely cause frustration and confusion to anyone not familiar with Linux who is trying to make a Linux port of their game. Also, while there are a few apps out there with it .bin is not a standard extension for executables in Linux. The typical thing done for almost every Linux app is to have no extension.


Thanks,
Nathan

@NathanWarden NathanWarden changed the title File path in save dialog automatically appended with correct extension if extension not manually added by the user. 1: File path in save dialog automatically appended with correct extension if not manually added by the user. 2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. Jan 15, 2015
@NathanWarden NathanWarden changed the title 1: File path in save dialog automatically appended with correct extension if not manually added by the user. 2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. 1: File path in save dialog automatically appended with correct extension if not manually added by the user.2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. Jan 15, 2015
@NathanWarden NathanWarden changed the title 1: File path in save dialog automatically appended with correct extension if not manually added by the user.2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. 1: File path in save dialog automatically appended with correct extension if not manually added by the user. 2: Removed .bin as default extension for Linux exports as it causes problems for common file managers. Jan 15, 2015
@adolson
Copy link
Contributor

adolson commented Jan 15, 2015

excellent! hopefully Juan will merge a bunch of these PRs soon, including this one. :)

@reduz
Copy link
Member

reduz commented Jan 15, 2015

looks great, does this work well for you? I didn't have time to test it yet
(have a work deadline for tomorrow and didn't have much time)

On Thu, Jan 15, 2015 at 6:36 PM, adolson notifications@github.com wrote:

excellent! hopefully Juan will merge a bunch of these PRs soon, including
this one. :)


Reply to this email directly or view it on GitHub
#1223 (comment).

@adolson
Copy link
Contributor

adolson commented Jan 16, 2015

Everything works fine for me, except for one minor thing.

If I try going to Save As and putting in the name of an already-existing file, choosing the file extension in the dropdown, then it errors and says "File format requested unknown: res://scene3"

@NathanWarden
Copy link
Contributor Author

Thanks, I can reproduce it here too. I'll try and get a fix up soon.

@NathanWarden
Copy link
Contributor Author

Okay, should be fixed now. :)

reduz added a commit that referenced this pull request Jan 17, 2015
1: File path in save dialog automatically appended with correct extension if not manually added by the user.  2: Removed .bin as default extension for Linux exports as it causes problems for common file managers.
@reduz reduz merged commit 07e63c3 into godotengine:master Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants