Skip to content

Use binary names instead of absolute paths in calls to OS::execute. #12074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2017
Merged

Use binary names instead of absolute paths in calls to OS::execute. #12074

merged 1 commit into from
Oct 15, 2017

Conversation

J08nY
Copy link
Contributor

@J08nY J08nY commented Oct 13, 2017

Now that #12009 is merged, we should let the system find the binary on
the users $PATH and don't assume we know where to look for them in
different distributions.

@J08nY
Use binary names instead of absolute paths in calls to OS::execute.
b1252ca 
Now that #12009 is merged, we should let the system find the binary on
the users $PATH and don't assume we know where to look for them in
different distributions.
@neikeq
Copy link
Contributor

neikeq commented Oct 13, 2017

Does execute seach through PATH now on all platforms?

@vnen
Copy link
Member

vnen commented Oct 13, 2017

Does execute seach through PATH now on all platforms?

#12009 solves this only for Unix derived OSes (Linux, MacOS, Android and iPhone). This PR doesn't touch other platforms though.

@J08nY
Copy link
Contributor Author

J08nY commented Oct 13, 2017

execute on UWP is not implemented, on windows it uses CreateProcessW which states that it searches the PATH:

The directory from which the application loaded.
The current directory for the parent process.
The 32-bit Windows system directory. Use the GetSystemDirectory function to get the path of this directory.
The 16-bit Windows system directory. There is no function that obtains the path of this directory, but it is searched. The name of this directory is System.
The Windows directory. Use the GetWindowsDirectory function to get the path of this directory.
The directories that are listed in the PATH environment variable. Note that this function does not search the per-application path specified by the App Paths registry key. To include this per-application path in the search sequence, use the ShellExecute function.

So that should work as well.

@akien-mga akien-mga merged commit a851546 into godotengine:master Oct 15, 2017
@aaronfranke aaronfranke added this to the 3.0 milestone Jan 26, 2020
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 4, 2025
@yangyey @SunChenWei
Implements classic search in the Output (EditorLog) panel, including:
d63912b 
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlighting of all matches, with distinction for the currently selected one
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals features
godotengine#12074 and godotengine#10249.

Co-authored-by: @SunChenWei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 4, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
fbc358f 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlighting of all matches, with distinction for the currently selected one
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals features  godotengine#12074 and godotengine#10249.
Co-authored-by: @SunChenWei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 4, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
80251a4 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlighting of all matches, with distinction for the currently selected one
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: @SunChenWei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 4, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
3479fb2 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: @SunChenWei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 5, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
045caa6 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 5, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
7c916c1 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <sunchenwei@tecnico.ulisboa.pt>
@yangyey yangyey mentioned this pull request Jun 5, 2025
Open
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 5, 2025
@yangyey @SunChenWei
editor: Add classic text search functionality to Output panel
8fe7915 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <sunchenwei@tecnico.ulisboa.pt>
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 7, 2025
@yangyey
editor: Add classic text search functionality to Output panel
6e31c7e 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <sunchenwei@tecnico.ulisboa.pt>

fix: re-added a line that was deleted by accident
yangyey added a commit to yangyey/godotwork that referenced this pull request Jun 19, 2025
@yangyey
editor: Add classic text search functionality to Output panel
a966cd7 
Implements classic search in the Output (EditorLog) panel, including:
- Search box with toggles for "Match Case" and "Whole Words"
- Navigation buttons for next/previous match
- Highlights matches, with distinction for the currently selected
- Scroll to active match when navigating

This improves usability for developers debugging or scanning log
output by allowing quick and flexible keyword searching.
This looks to implement what was referenced in godot-proposals
features  godotengine#12074 and godotengine#10249.
Co-authored-by: Sun Chenwei <sunchenwei@tecnico.ulisboa.pt>

fix: re-added a line that was deleted by accident

fix : inconsistent text and unwanted checkbox being pushed off to the right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@J08nY @neikeq @vnen @aaronfranke @akien-mga