Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileDialog: enlarge the file list a bit #11882

Merged
merged 1 commit into from Oct 22, 2017
Merged

FileDialog: enlarge the file list a bit #11882

merged 1 commit into from Oct 22, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2017

After:

Edit: changed the ratio from 4:1 to 4:3
image
image

Before:
screenshot from 2017-10-06 21-08-19screenshot from 2017-10-06 21-03-26

@djrm
Copy link
Contributor

djrm commented Oct 6, 2017

@Noshyaar maybe it would be better if the filter button shows all its contents, instead of clipping them.

@akien-mga
Copy link
Member

I like the change, but yeah something should be done for the filter drop-down list.

@ghost ghost removed the good first issue label Oct 18, 2017
@akien-mga akien-mga added this to the 3.0 milestone Oct 21, 2017
@akien-mga
Copy link
Member

Bump - any idea how to improve this clipping of the file type selector?

@djrm
Copy link
Contributor

djrm commented Oct 21, 2017

the easiest way in my opinion (might not work on all possible cases) is to reduce the size of the file name input, file names are not that long, also the text could be clipped some units before the arrow, i dont think godot has a feature to mark clipped text (like ..., or some fade)

@ghost
Copy link
Author

ghost commented Oct 22, 2017

Changed the ratio from 4:1 to 4:3

@akien-mga
Copy link
Member

Looks good.

@akien-mga akien-mga merged commit 6dd25b5 into godotengine:master Oct 22, 2017
@ghost ghost deleted the pr-filedialog branch October 22, 2017 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants