Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Mononoki font to Hack font #11309

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Conversation

djrm
Copy link
Contributor

@djrm djrm commented Sep 16, 2017

You can ❤️ if you like the current font (Mononoki https://madmalik.github.io/mononoki/) or 👍if you prefer the proposed font (Hack http://sourcefoundry.org/hack/), you can also discuss which one is better if that helps, also you can provide evidence about your arguments, in any case this might end up with a weighted pseudo-democratic voting.

here are screenshot of how they look in Godot:
Current (Mononoki)
screenshot from 2017-09-14 19-39-29

Hack
screenshot from 2017-09-15 19-25-48

@willt
Copy link
Contributor

willt commented Sep 16, 2017

Hack looks pretty nice to me. Maybe we should just have them both and let the user decide? :)

@ghost
Copy link

ghost commented Sep 16, 2017

Mononoki's capital O looks a bit too thin for me. Other than that they're both okay.

@ghost ghost added this to the 3.0 milestone Sep 16, 2017
@cbscribe
Copy link
Contributor

Good work! ((Hopefully you haven't sparked off a font war. :P)

@SirPigeonz
Copy link
Contributor

Hopefully no one judges from screenshots :D Mononoki is scaled down here.

@Geequlim
Copy link
Contributor

I hope this font can aligns CJK characters fine in the right way.

@Geequlim
Copy link
Contributor

image

@djrm
Copy link
Contributor Author

djrm commented Sep 17, 2017

@Geequlim, thats hack font.
screenshot from 2017-09-16 23-58-22

as far as i can tell none of these fonts support CJK, the one i've seen that supports CJK is NotoMono, but with the CJK variation

@willt
Copy link
Contributor

willt commented Sep 17, 2017

I don't see a lot of CJK characters in code. Wouldn't those mainly be in localization files? Doesn't seem like an issue to me.

@Geequlim
Copy link
Contributor

@willt It is not a serious issue.

@TeddyDD
Copy link

TeddyDD commented Sep 17, 2017

Related discussion #11321

@toger5
Copy link
Contributor

toger5 commented Sep 19, 2017

why is the font size bigger in your screenshot? just setting?
The current default font size is a little small too. so if you could increase it in that pr too would be good (for code editor not docs)

@djrm
Copy link
Contributor Author

djrm commented Sep 19, 2017

@akien-mga i think this is also safe to merge, it seems that people prefer the hack font.

@akien-mga akien-mga merged commit cd2ffdc into godotengine:master Sep 19, 2017
@djrm djrm deleted the pr_hack_font branch September 25, 2017 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants