-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Mononoki font to Hack font #11309
Conversation
Hack looks pretty nice to me. Maybe we should just have them both and let the user decide? :) |
Mononoki's capital O looks a bit too thin for me. Other than that they're both okay. |
Good work! ((Hopefully you haven't sparked off a font war. :P) |
Hopefully no one judges from screenshots :D Mononoki is scaled down here. |
I hope this font can aligns CJK characters fine in the right way. |
@Geequlim, thats hack font. as far as i can tell none of these fonts support CJK, the one i've seen that supports CJK is NotoMono, but with the CJK variation |
I don't see a lot of CJK characters in code. Wouldn't those mainly be in localization files? Doesn't seem like an issue to me. |
@willt It is not a serious issue. |
Related discussion #11321 |
why is the font size bigger in your screenshot? just setting? |
@akien-mga i think this is also safe to merge, it seems that people prefer the hack font. |
You can ❤️ if you like the current font (Mononoki https://madmalik.github.io/mononoki/) or 👍if you prefer the proposed font (Hack http://sourcefoundry.org/hack/), you can also discuss which one is better if that helps, also you can provide evidence about your arguments, in any case this might end up with a weighted pseudo-democratic voting.
here are screenshot of how they look in Godot:

Current (Mononoki)
Hack
