-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
[3.x] Android: Set minsdk to 21, workaround fseeko
error in Opus.
#111061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fseeko
error in Opus.
Looks great, will wait for @syntaxerror247 to review. I'll be pushing for some reviews so we can get out either 3.7 dev 1 (or failing that 3.6.2). |
I would also suggest prioritizing 3.6.2 solving these issues, there needs to be a stable 3.x version people can use to publish games. We should also evaluate whether iOS and macOS compatibility is still good in 3.6.x. For Windows and Linux usually there's not much evolution of the platform requirements. |
@InfoDevkota Have you tested the changes by exporting to an Android 5 device? |
@syntaxerror247 I had not tested. I just tried, was trying for Android 7.
and tried the export. I am getting
errors. Sorry first time here. |
@InfoDevkota You can test this using a custom template:
From the extracted files, select the android_release.apk in the export window. Now export! ![]() |
On my I choose the custom template. The game is being build, and running fine on Android 7 and Android 10. I don't have Android 5, I will try an emulator and update here. |
If you could make the custom template available for download, I could test it on my Android 6 device.
|
@Alex2782 as mentioned by @syntaxerror247 you can click on the Checks (14) on top of this PR. link. You can find the Artifacts 9 dropdown. and download "android templates" from there. direct link. Its a bit slow. |
Update: Its working fine on Android 5. (tested on emulator). The error message (before this update) was because I had not selected that x86 on Architectures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on Android 6 (API 23)
09-30 16:10:30.854 7217 7230 I godot : Godot Engine v3.7.dev.custom_build.e4cf5ff48 - https://godotengine.org
09-30 16:10:30.878 7217 7230 I godot : OpenGL ES 2.0 Renderer: Adreno (TM) 320
androidGradlePlugin: '8.6.1', | ||
compileSdk : 35, | ||
minSdk : 24, // Also update 'platform/android/export/export_plugin.cpp#DEFAULT_MIN_SDK_VERSION' | ||
minSdk : 21, // Also update 'platform/android/export/export_plugin.cpp#DEFAULT_MIN_SDK_VERSION' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there were issues with 21 as the min sdk as mentioned in #108433 (comment).. Does this PR validate that the referenced issues have been addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m4gr3d I had fixed that issue in that PR itself. Issue was that Kyle hadn't updated the ndk_platform
version from android-19 to android-21.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the fix
Thanks! |
Min SDK to 21.
this change seems to fix the
fseeko
on #108433 (comment).Also,
Can we please release 3.6.2 with just the changes so we can upload the apps to Play Console.