Skip to content

Conversation

paperjack93
Copy link

I added a short text explaining non-obvious functionality.

@paperjack93 paperjack93 requested a review from a team as a code owner September 22, 2025 07:46
@AThousandShips AThousandShips changed the title Added information about emit_particle in GPUParticles3D's docs Add information about emit_particle in GPUParticles3D's docs Sep 22, 2025
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 22, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Sep 22, 2025
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@paperjack93
Copy link
Author

build error seems unrelated

Emits a single particle. Whether [param xform], [param velocity], [param color] and [param custom] are applied depends on the value of [param flags]. See [enum EmitFlags].
The default ParticleProcessMaterial will overwrite [param color] and use the contents of [param custom] as [code](rotation, age, animation, lifetime)[/code].
[b]Note:[/b] [method emit_particle] is only supported on the Forward+ and Mobile rendering methods, not Compatibility.
[b]Note:[/b] A custom processing material shader that doesn't modify the transform is required for the [constant EMIT_FLAG_ROTATION_SCALE] flag to work correctly.
Copy link
Member

@Calinou Calinou Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more explicit:

Suggested change
[b]Note:[/b] A custom processing material shader that doesn't modify the transform is required for the [constant EMIT_FLAG_ROTATION_SCALE] flag to work correctly.
[b]Note:[/b] A custom particle shader that doesn't modify the transform is required for the [constant EMIT_FLAG_ROTATION_SCALE] flag to work correctly.

"Particle shader" refers to what controls the particles, where "material shader" may be understood as the rendering (BaseMaterial3D) shader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants