No range check in orthogonal camera #110740
Open
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #110653
This fix assumes it makes sense to ignore range checks for orthogonal cameras as they are meant to display objects regardless of distance.
is_orthogonal
to bothCullData
andVisibilityCullData
range_check
in_scene_cull
and in_visibility_cull
when the camera is orthogonalImportant:
_scene_cull
patched._scene_cull
and_visibility_cull
so I chose to apply the changes symmetricaIly._visibility_cull
I chose to clear all flags but I might be missing some use cases.