Skip to content

Conversation

lawnjelly
Copy link
Member

Fixes small regression from #107324:

The cached is_visible_in_tree flag wasn't updated when Spatials were hidden or shown out of tree.

While it didn't cause any obvious problems, it was a change to previous behaviour, so is undesirable. Keeping the flag up to date outside the tree is unlikely to cause any performance issues.

Notes

  • Caught this when testing a blob shadows project which set some lights to hidden while out of tree.
  • The regression testing code I left in for DEV_ENABLED builds did its job.

@lawnjelly lawnjelly added this to the 3.7 milestone Aug 28, 2025
@lawnjelly lawnjelly requested a review from a team as a code owner August 28, 2025 17:16
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@lawnjelly lawnjelly merged commit 040e769 into godotengine:3.x Aug 29, 2025
14 checks passed
@lawnjelly lawnjelly deleted the fix_visible_out_of_tree branch August 29, 2025 04:51
@lawnjelly
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants