Skip to content

Conversation

Maran23
Copy link
Contributor

@Maran23 Maran23 commented Aug 17, 2025

Fixes: #108890
Made sure that #34130 is still fixed and does not regress.

The fix is simple:
Since we are running the code in a while loop, we need to assign the spacing_char always and may reset it to 0 when we are in a new blank line (created by ENSURE_WIDTH).

rtl.mp4

cc @lawnjelly

@Maran23 Maran23 requested a review from a team as a code owner August 17, 2025 14:33
@KoBeWi KoBeWi added this to the 3.x milestone Aug 17, 2025
@lawnjelly lawnjelly modified the milestones: 3.x, 3.7 Aug 26, 2025
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work okay here.

Although I'm aware this area is prone to regressions, I suspect we'll just have to merge and see how we get on.

@lawnjelly lawnjelly merged commit d926ccf into godotengine:3.x Aug 26, 2025
14 checks passed
@lawnjelly
Copy link
Member

Thanks!

@lawnjelly lawnjelly added the cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants