Skip to content

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 13, 2025

This is just a small PR, in case there is a delay to merging #107369 before the next beta (that PR will change how we fast access children).

This fixes up the second case in _update_dirty_nodes() to use fast child access (that @Ivorforce noticed yesterday, I accidentally reverted it in #106244 😊 ).

Also accesses data.visible directly to avoid one thread guard.

Notes

  • There are also numerous unneeded thread guards around e.g. get_transform() in the function, but that needs a PR of its own.
  • This is purely performance, no change in behaviour.

@lawnjelly lawnjelly added this to the 4.5 milestone Jun 13, 2025
@lawnjelly lawnjelly requested a review from a team as a code owner June 13, 2025 11:26
@akien-mga akien-mga merged commit bec4f66 into godotengine:master Jun 13, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the scenetreefti_cachedchildren_fix branch June 15, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants