D3D12: Revert to CPPPATH for Mesa private headers #106413
Draft
+4
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trust me, Eldritch horrors lie in wait here. Let's go back to the previous brittle setup that worked. Fixes godotengine#106376. Also clean up some dead code.
|
Oh well it brings back a truckload of warnings :( |
|
I put in a PR over here: #106416. This is the solution we used in our fork. Hopefully this fixes it without bringing back the warnings. I will test out this PR to confirm whether or not it fixes things for us as well |
|
@akien-mga I tested it out... unfortunately the shot in the dark misses / doesn't work :( I tried both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust me, Eldritch horrors lie in wait here.
Let's go back to the previous brittle setup that worked.
Fixes #106376.
Also clean up some dead code.