Force weights on custom editor fonts when variable #106217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeJayLSP
force-pushed
the
variable-weights-editor
branch
from
d597f56 to
38726fc
Compare
DeeJayLSP
changed the title
DeeJayLSP
force-pushed
the
variable-weights-editor
branch
from
38726fc to
0d4d0d4
Compare
|
Added a description to both properties, explaining which weight will be used on each. |
bruvzg
approved these changes
Jun 5, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a variable font in Main Font and Main Font Bold, there is no way to tell which weight to use through the editor settings.
This defaults Main Font weight to 400 and Main Font Bold weight to 700, the default weights for Regular and Bold. Should only affect variable fonts.
The ideal would be to add a setting to control both variations and features like it's done with Code Font, but I wanted to take the easy way and use the default values. Some kind of setting could be added later.
Using Inter Variable on both Main Font and Main Font Bold
Before (everything defaults to Regular weight):
After (wording is slightly changed since I'm comparing it to 4.4.1 stable):