Add capitalized PRINT_VERBOSE
macro alongside the lowercase one
#106147
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Godot core team meeting on 2025-05-07, it was discussed that PR #100224 is a massive codebase-wide change that will conflict with many PRs and break compatibility with third-party modules. Therefore, there is a lot of hesitation with merging it for a minor improvement, which is itself not unanimously agreed on.
However, there is still the problem of the name conflict in godot-cpp GDExtension, which currently uses a work-around of using a function instead of a macro. This means that
print_verbose
in godot-cpp has different behavior compared to the macro in the engine, and is objectively slower for no good reason.This PR adds the capitalized
PRINT_VERBOSE
macro without changing all existing uses throughout the codebase. This allows us to gradually migrate without breaking every PR, and more importantly, allows us to add the capitalized macro to godot-cpp, which lets users get the behavior and performance benefits of the macro, while still having their code be compatible between in-engine C++ and godot-cpp GDExtension C++.