Skip to content

FTI - Fix SceneTreeFTI behaviour on exit tree #105973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

FTI - Fix SceneTreeFTI behaviour on exit tree #105973

merged 1 commit into from
May 1, 2025

Conversation

lawnjelly
Copy link
Member

Fixes #105970

Notes

  • I totally missed this during testing because none of the demos re-added objects to the scene tree.
  • When the flags got out of sync, the SceneTreeFTI would incorrectly think an object was already added to a list.
  • Localized the flag resets to a single function so less likely to miss any in future.

@lawnjelly lawnjelly added this to the 4.5 milestone May 1, 2025
@lawnjelly lawnjelly requested a review from a team as a code owner May 1, 2025 07:00
rburing
rburing approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@lawnjelly lawnjelly mentioned this pull request May 1, 2025
Merged
@sinewavey
Copy link

Thank you very much! This has indeed resolved the issue.

@lord-muad-dib
Copy link

had the same issue, the fix works, thanks!

@Repiteo Repiteo merged commit 730adf4 into godotengine:master May 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 1, 2025

Thanks!

@lawnjelly lawnjelly deleted the fti_fix_3d_exit_tree branch May 1, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rburing rburing rburing approved these changes

Assignees

No one assigned

Labels

bug regression topic:rendering topic:3d

Projects

None yet

Milestone

4.5

Development

Successfully merging this pull request may close these issues.

[4.5 dev] FTI / Physics interpolation produces visual artifacts for objects that leave and re-enter SceneTree

5 participants

@lawnjelly @sinewavey @lord-muad-dib @Repiteo @rburing