[Web] Fix separate_debug_symbols=yes and debug experience
#105808
+140
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
force-pushed
the
fix-web-separate-debug-symbols
branch
5 times, most recently
from
96bfefb to
d8057da
Compare
|
Did something go wrong during rebasing? |
Ooops. Seems so. |
adamscott
force-pushed
the
fix-web-separate-debug-symbols
branch
from
d8057da to
f2fce75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I put the PR for 4.5 as an upcoming (big) PR will need the
CreateTemplateZip()refactorThis PR actually makes
separate_debug_symbols=yeswork on the Web platform. Beforehand, the option was just ignored by the Web buildsystem.It also edit the Wasm loading (the JS files edited) in a way to keep intact as much as possible the
Responseof the wasm file. This makes debugging Godot possible using the C/C++ DevTools Support (DWARF) Chrome extension.It would be actually nice to use if only it wouldn't crash on breakpoints due to Godot being a little bit too big for its taste. (I think it's fixable, though, but it's up to Google)
The PR is also refactoring a little bit the
CreateTemplateZip()function in order to simplify it.