Jolt: Update to 5.3.0 #104449
Merged
Jolt: Update to 5.3.0 #104449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @jrouwe |
jrouwe
approved these changes
Mar 22, 2025
akien-mga
approved these changes
Apr 4, 2025
|
Thanks! |
|
Thank you ! |
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps Jolt Physics from jrouwe/JoltPhysics@f094082 (roughly version 5.2.1) to jrouwe/JoltPhysics@0373ec0 (version 5.3.0).
The official release notes aren't going to be entirely applicable here, since we were previously using a non-versioned commit, along with some cherrypicks on top of that, but most of it still applies: https://github.com/jrouwe/JoltPhysics/releases/tag/v5.3.0
This brings with it some fixes to
JPH::CylinderShapethat I would deem quite important, as seen in godot-jolt/godot-jolt#1049, along with changes needed for #100463 and #101588, as well as a slew of other bug fixes and optimizations.It also introduces a new
JPH::PhysicsSystem::SimCollideBodyVsBodycallback, which will allow us to greatly reduce the cost ofArea3Doverlapping with complex collision shapes, as discussed in jrouwe/JoltPhysics#1476, thereby allowing us to remove the dreadedphysics/jolt_physics_3d/simulation/areas_detect_static_bodiesproject setting that keeps tripping people up.I haven't tested this PR very extensively, but the 3D physics tests still seem fine, and GDQuest's Robo Blast still behaves as expected.