Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about set_deferred for CollisionShape3D disabled property #102520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add info about set_deferred for CollisionShape3D disabled property #102520

wants to merge 1 commit into from
+3 −3

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Feb 7, 2025

Fixes: #102377

@Giganzo Giganzo requested a review from a team as a code owner February 7, 2025 09:19
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Feb 7, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Feb 7, 2025
@akien-mga akien-mga changed the title Add info about set_deferred for CollisionShape3D disabled property Add info about set_deferred for CollisionShape3D disabled property Feb 7, 2025
Calinou
Calinou requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note should also be added to CollisionPolygon2D.disabled and CollisionPolygon3D.disabled. (It's already in CollisionShape2D.disabled.)

@Giganzo Giganzo force-pushed the CollisionShape3D-disabled-doc branch from 376db5c to b76b949 Compare February 11, 2025 20:56
@Giganzo
Copy link
Contributor Author

Giganzo commented Feb 11, 2025

This note should also be added to CollisionPolygon2D.disabled and CollisionPolygon3D.disabled. (It's already in CollisionShape2D.disabled.)

Changes made.

Should we use [b]Note:[/b] or is this good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release documentation enhancement
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

CollisionShape3D - Setting Disabled Boolean to False via Code Triggered by Area3D Doesn't Work
3 participants
@Giganzo @Calinou @AThousandShips