Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Rename classes in preparation for future restructure #102100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Navigation] Rename classes in preparation for future restructure #102100

wants to merge 1 commit into from
+1,096 −1,014

Conversation

AThousandShips
Copy link
Member

Related to:

But generally related to maintainability of this code for future changes, as discussed in RC

@AThousandShips AThousandShips added this to the 4.4 milestone Jan 27, 2025
@AThousandShips AThousandShips requested review from a team as code owners January 27, 2025 20:06
AThousandShips
AThousandShips commented Jan 27, 2025
View reviewed changes
@AThousandShips AThousandShips mentioned this pull request Jan 27, 2025
Open
1 task
smix8
smix8 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Heap should be moved as mentioned but else looks good.

Since this is only server internals and code style changes and done so we dont lose our sanity on rebase issues with those open major prs imo we should merge this asap.

@AThousandShips
Copy link
Member Author

Will move the heap tomorrow

@AThousandShips AThousandShips changed the title [Navigation] Renames in preparation for future restructure [Navigation] Rename classes in preparation for future restructure Jan 28, 2025
@akien-mga akien-mga modified the milestones: 4.4, 4.x Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:navigation
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @smix8 @akien-mga