Override mass properties for Area3D when using Jolt Physics
#102029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihe
force-pushed
the
jolt/area-mass-properties
branch
from
3a4fef5 to
f380b00
Compare
mihe
changed the title
Area3D when using Jolt PhysicsArea3D when using Jolt Physics
mihe
changed the title
Area3D when using Jolt PhysicsArea3D when using Jolt Physics
rburing
approved these changes
Jan 25, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101917.
Doing this resolves the assertion about "Invalid mass" when trying to use
ConcavePolygonShape3Dfor anArea3D.The reason for this assertion is that
Area3Dare implemented with what Jolt calls sensors, which are a type of body, and thus happen to have mass properties as well, which can't reasonably be calculated automatically for shapes likeConcavePolygonShape3D.Note that concave shapes for an
Area3Dis problematic for a number of reasons, as mentioned in the documentation forArea3D, but it seems to work on some basic level at least, and seems to be about as janky in Godot Physics already, so I guess it's fine to just allow it for now.