Re-create missing .uid files #100787
Open
Re-create missing .uid files #100787
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Dec 24, 2024
| @@ -1260,11 +1260,13 @@ void EditorFileSystem::_process_file_system(const ScannedDirectory *p_scan_dir, | |||
| } | |||
| } | |||
|
|
|||
| if (fi->uid == ResourceUID::INVALID_ID && ResourceLoader::exists(path) && !ResourceLoader::has_custom_uid_support(path) && !FileAccess::exists(path + ".uid")) { | |||
| // Create a UID. | |||
| if (ResourceLoader::exists(path) && !ResourceLoader::has_custom_uid_support(path) && !FileAccess::exists(path + ".uid")) { | |||
There was a problem hiding this comment.
Both ResourceLoader methods go through all loaders and check if the file is recognized. I think this can be improved.
|
I think this should probably print a warning if this happens. This is a user error, and we cannot necessarily create the correct new .uid file, so I think we need to make sure that the user is informed that their project might be messed up. |
KoBeWi
force-pushed
the
uid_be_like_'I'm_back'
branch
from
65731fa to
e0ca8be
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99779
The file is only created on editor restart, not sure how to detect that .uid file is deleted while the editor is running.