Add Ctrl+I/Cmd+I shortcut to trigger code completion
#100606
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
enhancement
cherrypick:4.3
Calinou
reviewed
Dec 21, 2024
Comment on lines
518
to
+519
| inputs.push_back(InputEventKey::create_reference(Key::SPACE | KeyModifierMask::CTRL)); | ||
| inputs.push_back(InputEventKey::create_reference(Key::I | KeyModifierMask::CMD_OR_CTRL)); |
There was a problem hiding this comment.
List the modifier first (it acts the same, but is more consistent with the rest of the codebase):
Suggested change
| inputs.push_back(InputEventKey::create_reference(Key::SPACE | KeyModifierMask::CTRL)); | |
| inputs.push_back(InputEventKey::create_reference(Key::I | KeyModifierMask::CMD_OR_CTRL)); | |
| inputs.push_back(InputEventKey::create_reference(KeyModifierMask::CTRL | Key::SPACE)); | |
| inputs.push_back(InputEventKey::create_reference(KeyModifierMask::CMD_OR_CTRL | Key::I)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user presses
Ctrl+I/Cmd+I, the code completion popup appears.Fixes godotengine/godot-proposals#11385