Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom --language-in arg for the Closure compiler #100525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Dec 17, 2024

This PR removes our custom set of --language-in for the Closure compiler, especially since emscripten recently adopted the default behavior of Closure, which is --language-in UNSTABLE since 3.1.71. Using any other language breaks our build. So this PR is needed not necessarily now, but if we ever want to update emscripten past 3.1.70.

See these links for more info:

This will enable us to streamline our code, including the use of public class fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants