Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection box movement/scaling to the animation bezier editor #100470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YeldhamDev
Copy link
Member

Implements godotengine/godot-proposals#3532 for the bezier editor.

Screencast_20241216_114037.webm

Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.

@Arnklit
Copy link
Contributor

Arnklit commented Dec 16, 2024

Thanks so much for this @YeldhamDev , this will be such an improvement to the Bezier editor. I've been trying it out a bit and I did see some weird behaviour when selecting some of the bezier handles after doing a multi selection.

godot.windows.editor.dev.x86_64_0dLHJal9pr.mp4

@YeldhamDev
Copy link
Member Author

@Arnklit This appears to be a preexisting bug unrelated to the PR (it also happens on 4.3). From what I tested, it seems to happen because the handle's position is being calculated relatively to the highlighted track.

@YeldhamDev YeldhamDev force-pushed the i_hate_math_so_much_you_would_not_believe branch from f92967a to 14c4216 Compare December 16, 2024 18:11
@YeldhamDev YeldhamDev added the bug label Dec 16, 2024
@YeldhamDev
Copy link
Member Author

It was a single line of code using the wrong variables. Added the fix in here too, why not.

@Arnklit
Copy link
Contributor

Arnklit commented Dec 16, 2024

It was a single line of code using the wrong variables. Added the fix in here too, why not.

Sorry I did not realise that was a pre-existing issue, thanks for including the fix. Tested again and yeah it's great now.

@Arnklit
Copy link
Contributor

Arnklit commented Dec 17, 2024

I had a go at adding in the cursor changing based on what handle you are dragging. Don't know if you want to incorporate that, otherwise I can do a PR for it when this one merges :). Arnklit@071f462

godot.windows.editor.dev.x86_64_WT7XvpX4gk.mp4

@YeldhamDev
Copy link
Member Author

@Arnklit I think it's probably better to be its own separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants