BoneAttachment3D transform is saved (Minor annoyance, Git unfriendly)

[temzky]

Tested versions

Reproducible in: 4.3 rc2, 4.2.2 stable

System information

Godot v4.3.rc2 - Windows 10

Issue description

As BoneAttachment3D gets connected to a bone in the editor, its Node3D transform gets automatically updated. And that's ok, but what's annoying that the transform (which is ignored anyway by default - "override pose" disabled) is saved to the scene file. I don't want the transform show up in my git commits every time I change the skeleton pose.

Steps to reproduce

Set up BoneAttachment3D and save the scene

Minimal reproduction project (MRP)

Set up BoneAttachment3D and save the scene

[akien-mga]

CC @TokageItLab

[TokageItLab]

This is not a bug.

When Override Pose is disabled, it is the intended behavior because "there should be a actual difference in the Pose of Skeleton3D", so the BoneAttachment will have a consistent difference with it.

In that case, as long as the Bone is correctly assigned to the Skeleton and the Skeleton is using Reset on Save in the AnimationMixer, there should be no difference in the Pose and therefore no difference in the BoneAttachment.

Since Skeleton has a rest value like a reset value, it might be possible to implement Reset on Save in Skeleton itself without AnimationMixer, however, it should not be implemented in core because it conflicts with AnimationMixer's Reset on Save.

If you really need it, you can only work around it by user script as follows:

@tool
extends Skeleton3D

func _notification(what: int) -> void:
	match what:
		NOTIFICATION_EDITOR_PRE_SAVE:
			reset_bone_poses()

[tangx246]

In that case, as long as the Bone is correctly assigned to the Skeleton and the Skeleton is using Reset on Save in the AnimationMixer, there should be no difference in the Pose and therefore no difference in the BoneAttachment.

I think that this is, in fact, a bug as when you assign the Bone to the Skeleton, and the Skeleton is using Reset on Save in the AnimationMixer, the bones themselves appear to be correctly resetting on save, but BoneAttachment3Ds do not reset on save.

This can be reproduced on Godot 4.3 stable

[TokageItLab]

Did you see the problem with reset on save not working in 4.2 as well? If not, then this is a different issue than this issue.

In 4.3, the BoneAttachment update timing has changed, so it may need to be fixed so that it waits for the deferred process at the reset on save, but I assume that was not the case in 4.2.

[tangx246]

Hmm I did not think of that. Unfortunately, I am not sure if this was happening on 4.2 as well :(