Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnails sometimes get cleared when the filesystem is docked to the bottom #90801

Closed
mieldepoche opened this issue Apr 17, 2024 · 0 comments · Fixed by #91471
Closed

Thumbnails sometimes get cleared when the filesystem is docked to the bottom #90801

mieldepoche opened this issue Apr 17, 2024 · 0 comments · Fixed by #91471
Labels
bug topic:editor
Milestone
4.3

Comments

@mieldepoche
Copy link
Contributor

mieldepoche commented Apr 17, 2024 •
edited
Loading

Tested versions

System information

linux

Issue description

I can't reproduce it reliably.
Sometimes, when hiding and showing the filesystem (when it's docked to the bottom), the thumbnails of the files will all be a default icon.

  • double clicking a file or switching directories makes the thumbnail show up again.

in this clip after opening the theme, I double-click a scene file and the thumbnails reapear:

simplescreenrecorder-2024-04-18_08.41.22.mp4

Steps to reproduce

Use the engine for long enough with the filesystem docked at the bottom of the editor.

Minimal reproduction project (MRP)

any
@aaronp64 aaronp64 mentioned this issue May 2, 2024
Merged
@AThousandShips AThousandShips added this to the 4.3 milestone May 2, 2024
dimitry- pushed a commit to AndroidWasm/godot that referenced this issue May 16, 2024
@aaronp64 @dimitry-
Fix FileSystemDock thumbnails sometimes not displaying
1e00a91 
There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible:
	- current_path == "Favorites", due to p_path not starting with "Favorites"
	- current_path == "res://", due to current_path having last "/" trimmed for comparison
	- current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory

This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon.

Fixes godotengine#90801
Fixes godotengine#91432
MewPurPur pushed a commit to MewPurPur/godot that referenced this issue Jul 11, 2024
@aaronp64 @MewPurPur
Fix FileSystemDock thumbnails sometimes not displaying
0d4185a 
There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible:
	- current_path == "Favorites", due to p_path not starting with "Favorites"
	- current_path == "res://", due to current_path having last "/" trimmed for comparison
	- current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory

This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon.

Fixes godotengine#90801
Fixes godotengine#91432
2nafish117 pushed a commit to 2nafish117/godot that referenced this issue Aug 5, 2024
@aaronp64 @2nafish117
Fix FileSystemDock thumbnails sometimes not displaying
d72a628 
There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible:
	- current_path == "Favorites", due to p_path not starting with "Favorites"
	- current_path == "res://", due to current_path having last "/" trimmed for comparison
	- current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory

This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon.

Fixes godotengine#90801
Fixes godotengine#91432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix FileSystemDock thumbnails sometimes not displaying aaronp64/godot
2 participants
@mieldepoche @AThousandShips