Changing visibility of CSG-nodes crashes the editor silently (Godot 4.1.4 RC 2)

[GNSS-Stylist]

Tested versions

• Reproducible in 4.1.4 RC 2
• Not reproducible in 4.1.3 stable
• Not reproducible in 4.3 dev5
• Not reproducible in 4.2.1 stable

System information

Godot v4.1.4.rc2 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 31.0.15.5176) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)

Issue description

Changing the visibility of CSG-shapes (tested with CSGBox3D, though) crashes the editor after a short freeze. No messages are printed into the console. It doesn't make any difference if visibility is changed from the parent node or some of the CSG-nodes. This does not happen in version 4.1.3 stable.
Video:

2024-03-18.13-37-12.mp4

Although not seen in the video it doesn't matter which way the visibility is changed or which node's visibility is changed (parent or any CSG-node).

Steps to reproduce

• Create a CSG-node
• Change CSG-node's visibility. Editor freezes and shuts down after a while.

Minimal reproduction project (MRP)

CSGVisibilityChangeCrash.zip

[AThousandShips]

Sounds like:

• Making a CSG Mesh visible again crashes Godot 4.2 beta4 #84304

Which was caused by something cherry picked for 4.1.4

[GNSS-Stylist]

Investigated this a bit and it indeed looks like the cherry-picked commit cf61f5e (PR #84174 ) is related to this. Editor doesn't crash after reverting changes by that commit. @jsjtxietian

Tested also 4.3.dev5 and 4.2.1.stable and crash doesn't happen. So the change is somehow incompatible with 4.1? I could investigate this deeper but I don't understand enough of the intricacies in this.

[jsjtxietian]

Yes looks like the fix (#84338) should also be cherry-picked?

[GNSS-Stylist]

Can confirm that cherry-picking the aforementioned PR (#84338) fixes the editor crash with the project it first manifested in and with the MRP above. (Although I "cherry picked" it by copy-paste).

[akien-mga]

Should be fixed in 4.1.4 RC 3 and stable.

[GNSS-Stylist]

Just confirming: Tried 4.1.4 RC3 with the MRP and the project where this first manifested in and the crash doesn't happen any more.