Disabling depth prepass in the Project Settings breaks opaque material rendering

[Calinou]

• Related to Vulkan: Alpha Antialiasing renders into depth prepass when it shouldn't, resulting in unexpected black pixels #82637.

Godot version

4.0.stable, 4.1.1.stable, 4.2.dev fe8a58b

System information

Godot v4.2.dev (fe8a58b) - Fedora Linux 38 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 535.113.01) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

Disabling depth prepass in the Project Settings breaks opaque material rendering. All opaque objects will no longer be rendered until the project is reloaded.

This occurs both in the editor and running project (if toggling the project setting's value with a script).

simplescreenrecorder-2023-10-05_17.55.33.mp4

Steps to reproduce

• Use the Forward+ rendering method. (I can't reproduce this when using the Compatibility rendering method, but toggling the setting makes no performance difference there. Does the setting have an effect when using Compatibility?)
• Disable Rendering > Driver > Depth Prepass > Enable in the Project Settings, or use the following in a script:

ProjectSettings.set_setting("rendering/driver/depth_prepass/enable", not bool(ProjectSettings.get_setting("rendering/driver/depth_prepass/enable")))

Minimal reproduction project

test_depth_prepass.zip

[clayjohn]

Is the setting set to restart when changed (I.e. using GLOBAL_DEF_RST)? It requires a restart after changing or else all opaque materials will be broken

[Calinou]

Is the setting set to restart when changed (I.e. using GLOBAL_DEF_RST)? It requires a restart after changing or else all opaque materials will be broken

No, but I remember the setting being changeable without having to restart (this was when I initially added the option). I guess this is no longer the case due to some internal optimizations.

[clayjohn]

Is the setting set to restart when changed (I.e. using GLOBAL_DEF_RST)? It requires a restart after changing or else all opaque materials will be broken

No, but I remember the setting being changeable without having to restart (this was when I initially added the option). I guess this is no longer the case due to some internal optimizations.

Ya, that's right

A note for potential bug fixer, the solution here is to change the definition of this project setting from GLOBAL_DEF to GLOBAL_DEF_RST

[Lunarisnia]

I would love to fix this. Can I get assigned to this issue?

[Calinou]

I would love to fix this. Can I get assigned to this issue?

For future reference, we only use the assignees feature for core contributors (and we don't always use it in the first place). Since contributors can leave at any time for any reason, we'd rather avoid a situation where nobody is working on an issue because it's assigned to someone who is no longer active.

You can open a pull request nonetheless 🙂

[Lunarisnia]

Sounds great. Thank you for the info