[Chrome] Input actions get stuck in the pressed state on web builds

[nyxkn]

Godot version

master (a2f90d5)

System information

Godot v4.2.dev (a2f90d5) - Arch Linux #1 ZEN SMP PREEMPT_DYNAMIC Thu, 21 Sep 2023 12:54:31 +0000 - Tty - GLES3 (Compatibility) - AMD Radeon R9 380 Series (tonga, LLVM 16.0.6, DRM 3.54, 6.5.4-zen2-1-zen) () - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

Input actions get stuck in the pressed state even after releasing the action's key.

This happens only on web exports. I can reproduce the issue reliably on the latest Chrome/Chromium 117. It does not seem to happen on Firefox.

Steps to reproduce

It happens while pressing/releasing keys. One way I've found to reliably reproduce this issue is the following:

Assume we have 3 actions (A, B, C) with their respective keys assigned. Press and hold A, B and C, one after the other. I.e. press and hold A, then add B, then C. Now you're holding down three keys. Now, release the three keys in the same order they were pressed. I.e. release A, then release B, then release C. When you release key C, observe how is_key_pressed() for C returns false, but is_action_pressed() for C still returns true.

I've created a small test project with a basic character controller that moves with the built-in actions ui_{left,right,up,down}. The controller moves by reading the action pressed status with Input.get_vector(). Debug text shows the status of is_key_pressed and is_action_pressed.

To reproduce with this project, you can use any three of these direction keys to trigger the bug. E.g. press and hold left, down, right. Then release left, down, right. Observe how the character keeps moving right, and the action for right still shows as pressed (while the key doesn't).

vokoscreenNG-2023-10-03_16-37-59.mp4

Minimal reproduction project

bug-actions.zip

[vmikhav]

I found similar/the same issue starting from 4.2dev4. After calling Input.action_press with one button several times calling Input.action_release doesn't release the button, it should be called several times (probably as many as action_press was called). Here is the reproducing project
test.zip

[akien-mga]

CC @KoBeWi @Sauermann

[daniel080400]

Got the same issue with 4.2-beta2 too

[MetRiko]

Just tested it with 4.2-beta3 with my jam game - issue is still there unfortunately : /
I tested it on the itch.io using Edge browser.
I tried two movement implementations:
a) just with Input.get_vector(...)
b) using the classic if elif... approach:

func _process(_delta):
	var vec := Vector2()
	if Input.is_action_pressed("ui_left"):
		vec.x = -1.0
	elif Input.is_action_pressed("ui_right"):
		vec.x = 1.0
	if Input.is_action_pressed("ui_up"):
		vec.y = -1.0
	elif Input.is_action_pressed("ui_down"):
		vec.y = 1.0
	_move_direction = vec.normalized()

In both cases bug was still replicable. It's sometimes very hard to get but it's happening frequently enough to make sharing jam games using web builds really risky.

[Sauermann]

I can confirm this issue with Chromium on Linux X11.
Bisecting lead me to #80859.
In my tests, I was unable to replicate this with Firefox (2 minutes of trying)