SpinBox resets to min_value or max_value when right-clicked with a disabled context menu

[dreadpon]

Godot version

v4.1.stable.official [9704596]

System information

Windows 10 4.1-stable Forward+

Issue description

After calling SpinBox.set_context_menu_enabled(false), any right click from unfocused state to this SpinBox will reset its value to either min_value or max_value (what affects this choice is unclear to me).

This seems connected to #31069 and possibly #79507

Steps to reproduce

1. Launch the scene res://spinbox_input/spinbox_input.tscn
2. Type a number (1- 99998) in leftmost SpinBox
3. Select the SpinBoxin the middle
4. Right click the leftmost SpinBox
5. Observe how it resets to either 0 or 99999 (its min and max values)
6. You can try the same with the middle SpinBox (with enabled context menu) and rightmost LineEdit (with disabled context menu); both will behave as expected

Minimal reproduction project

spinbox_reset.zip

[jackwilsdon]

This appears to be intentional, right clicking the bottom half of a SpinBox sets the value to minimum, right clicking the top half sets the value to maximum:

godot/scene/gui/spin_box.cpp

Line 146 in 1989061

bool up = mb->get_position().y < (get_size().height / 2);

godot/scene/gui/spin_box.cpp

Lines 161 to 164 in 1989061

	case MouseButton::RIGHT: {
	line_edit->grab_focus();
	set_value((up ? get_max() : get_min()));
	} break;

[dreadpon]

This seems very unintuitive, not to mention undocumented
It's also a pretty drastic functionality (fully resets the number) that cannot be turned off

This dates back all the way to open sourcing of Godot, so perhaps it's time we review this functionality?
Perhaps it's no longer needed?
Or at the very least we could introduce a flag to disable it?

I'm sure I'm not the only one who would be weirded out by this functionality in a user-facing application

[jackwilsdon]

@dreadpon it does sound like this should be an optional setting - it's worth opening a proposal: https://github.com/godotengine/godot-proposals

[jackwilsdon]

In the meantime, you can attach the following script to a SpinBox to disable this functionality:

extends SpinBox

func _gui_input(event):
	if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_RIGHT:
		get_viewport().set_input_as_handled()

[jsjtxietian]

I think we should update the document to mention this for now.