GLES3: Godot game is not loading shadow_atlas_size defined in project settings

[WhalesState]

Godot version

4.1.1-stable

System information

Windows 10

Issue description

When the project loads in editor, all the settings defined in project settings will be loaded over the default values, but when running the game nearly 95% of them will be ignored resulting in just loading the default settings.

here it's just loading only 4 variables from project setting and i have added the fifth in this pull request #80151

[AThousandShips]

They are loaded but not in main.cpp, as most settings they are loaded in the server?

Like here:

godot/servers/rendering/renderer_rd/environment/sky.cpp

Lines 722 to 724 in 237bd0a

	roughness_layers = GLOBAL_GET("rendering/reflections/sky_reflections/roughness_layers");
	sky_ggx_samples_quality = GLOBAL_GET("rendering/reflections/sky_reflections/ggx_samples");
	sky_use_cubemap_array = GLOBAL_GET("rendering/reflections/sky_reflections/texture_array_reflections");

godot/servers/rendering/renderer_scene_cull.cpp

Lines 4148 to 4150 in 237bd0a

	indexer_update_iterations = GLOBAL_GET("rendering/limits/spatial_indexer/update_iterations_per_frame");
	thread_cull_threshold = GLOBAL_GET("rendering/limits/spatial_indexer/threaded_cull_minimum_instances");
	thread_cull_threshold = MAX(thread_cull_threshold, (uint32_t)WorkerThreadPool::get_singleton()->get_thread_count()); //make sure there is at least one thread per CPU

godot/servers/rendering/renderer_rd/renderer_scene_render_rd.cpp

Lines 1289 to 1309 in 237bd0a

	RSG::camera_attributes->camera_attributes_set_dof_blur_bokeh_shape(RS::DOFBokehShape(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_shape"))));
	RSG::camera_attributes->camera_attributes_set_dof_blur_quality(RS::DOFBlurQuality(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_quality"))), GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_use_jitter"));
	use_physical_light_units = GLOBAL_GET("rendering/lights_and_shadows/use_physical_light_units");
	screen_space_roughness_limiter = GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/enabled");
	screen_space_roughness_limiter_amount = GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/amount");
	screen_space_roughness_limiter_limit = GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/limit");
	glow_bicubic_upscale = int(GLOBAL_GET("rendering/environment/glow/upscale_mode")) > 0;
	directional_penumbra_shadow_kernel = memnew_arr(float, 128);
	directional_soft_shadow_kernel = memnew_arr(float, 128);
	penumbra_shadow_kernel = memnew_arr(float, 128);
	soft_shadow_kernel = memnew_arr(float, 128);
	positional_soft_shadow_filter_set_quality(RS::ShadowQuality(int(GLOBAL_GET("rendering/lights_and_shadows/positional_shadow/soft_shadow_filter_quality"))));
	directional_soft_shadow_filter_set_quality(RS::ShadowQuality(int(GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/soft_shadow_filter_quality"))));
	environment_set_volumetric_fog_volume_size(GLOBAL_GET("rendering/environment/volumetric_fog/volume_size"), GLOBAL_GET("rendering/environment/volumetric_fog/volume_depth"));
	environment_set_volumetric_fog_filter_active(GLOBAL_GET("rendering/environment/volumetric_fog/use_filter"));
	decals_set_filter(RS::DecalFilter(int(GLOBAL_GET("rendering/textures/decals/filter"))));
	light_projectors_set_filter(RS::LightProjectorFilter(int(GLOBAL_GET("rendering/textures/light_projectors/filter"))));

[WhalesState]

what about rendering/2d/shadow_atlas/size ? can you confirm that it's loaded on start ? i will search other 3d shadow settings if they are loaded too

[AThousandShips]

Found with a simple search in a few seconds:

godot/servers/rendering/renderer_rd/renderer_canvas_render_rd.cpp

Line 2609 in 237bd0a

state.shadow_texture_size = GLOBAL_GET("rendering/2d/shadow_atlas/size");

[WhalesState]

this just loads it for vulkan, what about canvas_renderer_gles3 ? can you confirm that they loads in gles3 too ?

[AThousandShips]

Are you sure? This is the rd renderer, not the forward renderer AFAIK

But I'd suggest you search around yourself, not something I have time for

[Calinou]

Are you sure? This is the rd renderer, not the forward renderer AFAIK

rd (RenderingDevice) renderer code affects Forward+ and Mobile, but not Compatibility. This is because RenderingDevice only tailors to modern low-level graphics APIs (Vulkan, Direct3D 12, Metal, WebGPU).

[WhalesState]

trust me i have tried it with the stable release using gles3 renderer and it doesn't load the rendering/2d/shadow_atlas/size on running the game and it will be ignored on game startup but not in editor

[AThousandShips]

Then it should be handled under the appropriate place in the compatibility renderer code

[WhalesState]

so i should load them in canvas_renderer_gles3 if something is messing for 2d, and also check the scene_renderer_gles3 if something is messing in 3d, right ?

[AThousandShips]

Yes exactly, look at the equivalent for rd and apply when applicable

[WhalesState]

https://github.com/godotengine/godot/blob/master/drivers/gles3/rasterizer_scene_gles3.cpp
most of the functions are left empty and it's just loading only 3 variables from project settings, this will require so much work and should be addressed in a new issue, i will just review the rasterizer_canvas_gles3 and push what's missing.

[WhalesState]

fixed in #80151, closing now