Skip to content

VideoStream calls wrong virtual function on set_paused #79709

Closed
@rsubtil

Description

Godot version

4.1.dev (latest)

System information

Arch Linux

Issue description

cc @kidrigger

With #62737, the set_paused method is not calling the correct virtual function:

void VideoStreamPlayback::set_paused(bool p_paused) {
GDVIRTUAL_CALL(_is_playing, p_paused);
}

This ends up not being much of an issue because the video player internally stops processing the playback when paused, but I think this is currently wrong nevertheless.

Steps to reproduce

Minimal reproduction project

N/A - Not viable

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions