Using as_text() on a physical key InputEvent returns an empty string silently #61508
Description
Godot version
3.4.4
System information
Linux, Debian 11
Issue description
As of now, when you call the as_text method in a physical key InputEvent, it simply returns an empty string. I would expect it to return either an error telling the user that the method does not function with physical keys, or for it to return the key in that physical position.
All in all, I realize this is a very small issue, and you can currently fix it by simply using keys instead of physical keys, but I think it should do something other than silently return nothing. It should be more obvious something is wrong.
Steps to reproduce
- Make a new Godot project
- Add an action in the Input Map, in my case I called it test_input
- Assign a physical key to that action, in my case I chose A
- Create a Control Node
- Add a script to the Control Node
extends Control
func _ready():
var event: InputEvent = InputMap.get_action_list("test_input")[0]
var faulty_as_text: String = event.as_text()
print(faulty_as_text)
- Save and run the scene
It will not print anything, and if you add a breakpoint, you will see that although there is an InputEvent Object in event, but faulty_as_text remains empty. It will do this silently.
Minimal reproduction project
This project simply follows the above instructions. Simply run it and behold.