Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan Mobile backend: Radiance prefiltering worsens rough reflection quality #58631

Closed
Tracked by #55871
Calinou opened this issue Feb 28, 2022 · 3 comments
Closed
Tracked by #55871

Comments

@Calinou
Copy link
Member

Calinou commented Feb 28, 2022

Godot version

4.0.alpha (0393057)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 495.46)

Issue description

Radiance prefiltering looks good on the Vulkan Clustered backend, but it doesn't see the same improvements in the mobile backend (running with desktop default settings). Reverting #58177 restores filtering quality to what it was before in the Vulkan Mobile backend (although the Real-Time filter mode still exhibits the issue).

Vulkan Clustered

High Quality Real-Time
2022-02-28_15 41 31 2022-02-28_15 42 37

Vulkan Mobile

High Quality Real-Time
2022-02-28_15 43 44 2022-02-28_15 43 47
Closeups
High Quality

2022-02-28_15 44 19

Real-Time

2022-02-28_15 44 05

Vulkan Mobile (with #58177 reverted)

High Quality Real-Time
2022-02-28_15 48 19 2022-02-28_15 48 23
Closeups
High Quality

2022-02-28_15 48 43

Real-Time

2022-02-28_15 48 49

Steps to reproduce

  • Use an HDRI panorama sky from a website such as Poly Haven.
  • Add meshes with rough materials to the scene.
  • Switch to the Vulkan Mobile backend in the project settings (search for back end).
  • Restart the editor.

Minimal reproduction project

tests/3d/test_pbr_radiance_high_quality.tscn and tests/3d/test_pbr_radiance_real_time.tscn in https://github.com/Calinou/godot-rendering-tests

@clayjohn
Copy link
Member

This may be related to mobile not using the full HDR range. I wonder if your clamping PR (#58164) would fix this

@Calinou
Copy link
Member Author

Calinou commented Oct 10, 2022

This may be related to mobile not using the full HDR range. I wonder if your clamping PR (#58164) would fix this

I tried and the clamping doesn't resolve the issue. This is made more evident by #67172, which only uses a SDR sky (ProceduralSkyMaterial does not use overbright colors in its default settings).

@clayjohn clayjohn self-assigned this Oct 11, 2022
@Calinou
Copy link
Member Author

Calinou commented Nov 11, 2022

I checked the minimal reproduction project and can confirm this was fixed by #68511.

Screenshots from 4004f3f:

Forward Clustered

High Quality Real-Time
2022-11-11_21 30 30 webp 2022-11-11_21 31 35 webp

Forward Mobile

High Quality Real-Time
2022-11-11_21 31 04 webp 2022-11-11_21 31 48 webp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants