UI focus change is triggered too often when using gamepad analog stick to navigate menus (does not occur with D-pad or keyboard)

[rick551a]

Godot version

3.4 stable

System information

Windows10, Nvidia

Issue description

Navigating a menu with gamepad left stick axis is impossible using the default settings.

Cannot focus on controls in the usual manner.
I've encountered this on older versions too.

Steps to reproduce

1)Create a few contols on a 2D scene.

2)add gamepad left stick axis down to 'ui_down' & gamepad left stick axis up to 'ui_up' in Input under project settings

3)Try to navigate the controls using the left axis

4)Note you cannot focus like normal (like the way D-Pad works OK)

Minimal reproduction project

Small sample project: https://ufile.io/uqvtj8wq
Bugsquad edit: Re-uploaded to GitHub: GamepadFocusBug3_4.zip

Open project, run scene.

Click the first checkbox control with mouse.
Now try to use left stick axis on gamepad to navigate up and down the controls. Its impossible!

[Calinou]

This was implemented by #31880, and it works in some projects I've developed such as https://github.com/Calinou/escape-space.

[rick551a]

I just checked it on your game Escape space, the left stick navigation issue is here too.

See flv video of menu screen:
https://ufile.io/5875zngv

[Calinou]

This was confirmed here: https://godotengine.org/qa/120771/analog-stick-rapidly-changes-focus-of-ui-nodes

cc @pouleyKetchoupp

[pouleyKetchoupp]

It's a regression in 3.4. It works fine in 3.3.4-stable, and the issue is already present in 3.4-beta1.

The next step to investigate is to do a git bisect between faf3f88 (3.3.4-stable) and 207fb16 (3.4-beta1) and test with a gamepad to figure out how it broke.

[pouleyKetchoupp]

I'm adding a junior job tag for anybody who would be interested in investigating the issue (see my comment above).

Note that fixing the issue itself will probably be a bit involved and might not be a fit for junior job.

[Calinou]

I'm looking into bisecting this issue.

Edit: I've bisected between faf3f88 (good) and 207fb16 (bad) and couldn't reproduce this in https://github.com/Calinou/escape-space with any of the commits… I'll let someone else do the bisecting.