Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Baking VoxelGI causes Editor Hang if no meshes have global illumination set to either Baked or Dynamic #53348

Closed
Tracked by #55328
sairam4123 opened this issue Oct 3, 2021 · 21 comments

Comments

@sairam4123
Copy link

Godot version

4.0.dev ab063ade7

System information

Windows 10, Nvidia GeForce GTX 1050, 27.21.14.5771

Issue description

Baking VoxelGI causes Editor Hang, I'm trying to bake VoxelGI and clicking Bake GI Probe causes Editor hang and I can't find any workarounds for this.

Steps to reproduce

  1. Add VoxelGI
  2. Set Extents
  3. Click Bake GI Probe.
  4. Observe the Editor hang.

Minimal reproduction project

No response

@INdIEDeV016
Copy link

INdIEDeV016 commented Oct 3, 2021

In my case, after I hit Bake, the editor sits for a moment (hangs), then it again starts working. But it seems that it didn't bake anything and also pushes a error spam...

In the output panel:
image

In the console:
image

It seems to confront with the new Rendering Device

@Calinou Calinou added this to the 4.0 milestone Oct 3, 2021
@Calinou Calinou changed the title [Godot 4] Baking VoxelGI causes Editor Hang Vulkan: Baking VoxelGI causes Editor Hang Oct 3, 2021
@Calinou
Copy link
Member

Calinou commented Nov 28, 2021

@sairam4123 @INdIEDeV016 Can you upload a minimal reproduction project? Despite trying this on several projects with both baked and dynamic meshes, I can't reproduce this issue on 4.0.dev.custom_build [52b7d5f] (Linux, GeForce GTX 1080).

@sairam4123
Copy link
Author

I can try it again, do you have a prebuilt version for Windows?

@Calinou
Copy link
Member

Calinou commented Nov 28, 2021

I can try it again, do you have a prebuilt version for Windows?

https://hugo.pro/projects/godot-builds/ as always 🙂

@sairam4123

This comment has been minimized.

@INdIEDeV016
Copy link

INdIEDeV016 commented Dec 2, 2021

@Calinou Alright, it works in v4.0.dev.custom_build [2681d93b8]. But when I changed the gi_mode property of some MeshInstance Nodes and after clicking bake in VoxelGI, the editor suffered lags. The FPS fell below 5. Edit: Can't reproduce the error anymore 😅

OS: Windows 10
Graphics Card: NVIDIA GeForce GT 1030

image

@Calinou

This comment has been minimized.

@sairam4123
Copy link
Author

sairam4123 commented Dec 2, 2021

I can still reproduce this issue on build 702ffc624, the editor hangs and spits out this error.
image

OS: Windows 11 21H2
Graphics card: NVIDIA GeForce GTX 1050

@Calinou

Will test out on a new project.
Can reproduce on a new project as well.

test_project.zip

@INdIEDeV016
Copy link

It looks like a Windows 11 specific error

@INdIEDeV016
Copy link

INdIEDeV016 commented Dec 2, 2021

Minimal reproduction: (Even though there is no error in my project for v4.0.dev.custom_build [2681d93b8]):

  1. Start a fresh project
  2. Click 3D scene button
  3. Add 2 MeshInstance3D Nodes
  4. Configure one mesh as a Cylinder other a Plane
  5. Change the gi_mode of Cylinder Mesh Instance to dynamic and other (the Plane) as baked
  6. Add VoxelGI Node and click Bake GI

@sairam4123
Copy link
Author

Minimal reproduction: (Even though there is no error in my project):

  1. Start a fresh project
  2. Click 3D scene button
  3. Add 2 MeshInstance3D Nodes
  4. Configure one mesh as a Cylinder other a Plane
  5. Change the gi_mode of Cylinder Mesh Instance to dynamic and other (the Plane) as baked
  6. Add VoxelGI Node and click Bake GI

This works.

@INdIEDeV016
Copy link

This works.

So, no need to reopen this issue, right?

@sairam4123
Copy link
Author

sairam4123 commented Dec 2, 2021

This works.

So, no need to reopen this issue, right?

It shouldn't crash if I didn't set the global illumation to baked or dynamic right?
Maybe there should be a configuration warning.

@INdIEDeV016
Copy link

This works.

So, no need to reopen this issue, right?

It shouldn't crash if I didn't set the global illumation to baked or dynamic right?

Didn't test that aspect

@Calinou Calinou reopened this Dec 2, 2021
@Calinou Calinou changed the title Vulkan: Baking VoxelGI causes Editor Hang Vulkan: Baking VoxelGI causes Editor Hang if no meshes have global illumination set to either Baked or Dynamic Dec 2, 2021
@INdIEDeV016
Copy link

INdIEDeV016 commented Dec 3, 2021

@sairam4123 Well, it seems VoxelGI won't work if we don't set any gi_mode for the MeshInstance3D. (i.e set it to disabled)

image

The warning is shown even if I click Bake GI Probe

@INdIEDeV016
Copy link

INdIEDeV016 commented Dec 3, 2021

Oh yeah, but now if I change the gi_mode from Disabled to Dynamic for the Cylinder, then the editor starts performing very badly. It starts using 100% of my GPU in the Task Manager

@Calinou
Copy link
Member

Calinou commented Dec 3, 2021

Oh yeah, but now if I change the gi_mode to Disabled to Dynamic for the Cylinder, then the editor starts performing very badly. It starts using 100% of my GPU in the Task Manager

This is a known issue, see #55359.

@INdIEDeV016

This comment has been minimized.

@INdIEDeV016
Copy link

Found some errors. I don't know if it's related.....
image

@Calinou
Copy link
Member

Calinou commented Dec 3, 2021

Found some errors. I don't know if it's related.....

The layer manifest files message is unrelated – it's being tracked in #45725.

@Calinou
Copy link
Member

Calinou commented Dec 8, 2021

Duplicate of #36121 (same cause).

@Calinou Calinou closed this as completed Dec 8, 2021
@Calinou Calinou removed this from the 4.0 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants