TabContainer resets visibility to first tab in editor

[chucklepie]

Godot version

3.3 stable

System information

linux mint

Issue description

You're working on a single tab and need to switch to another scene or code. When you go back, whatever tab(s) you had selected is/are removed and the first one is selected.

This is really very annoying and forces you to constantly update visibility in the editor or temporarily move your tab (if you are editing just one) to the very top.

btw, It wouldn't be 'as bad' if you could drag items down (but still a pain) but Godot stops you from moving items to the bottom of the list because when at the bottom it eithier changes level to one before or one after, it will not let you move a sibling to be the last one.

Steps to reproduce

1. create a tab container with multiple tabs
2. select one tab
3. change to another open scene then go back

Minimal reproduction project

game.zip

[YuriSizov]

Can you demonstrate what you do with a video? Those steps are not enough to reproduce the issue. Changes to the visibility and selection in the scene dock are preserved when you switch between the scenes.

[chucklepie]

Sure. I didn't because I presumed it was simple and in case it was already a case. Give me a few minutes.

[chucklepie]

@pycbouh
In the video, TabDemo is selected and visible, switch scene, switch back and it's now at the first. I repeat with multiple and the same happens.

bug-tabcontainer2.mp4

[timothyqiu]

The supposed way of switching tabs is changing the Current Tab property of TabContainer I think.

The editor is trying to re-sync the scene with Current Tab.

[Calinou]

btw, It wouldn't be 'as bad' if you could drag items down (but still a pain) but Godot stops you from moving items to the bottom of the list because when at the bottom it eithier changes level to one before or one after, it will not let you move a sibling to be the last one.

You can select a node and use Ctrl + Up/Ctrl + Down to move it in the Scene tree dock. Using the keyboard is more precise than using drag-and-drop for this kind of stuff.

[timothyqiu]

btw, It wouldn't be 'as bad' if you could drag items down (but still a pain) but Godot stops you from moving items to the bottom of the list because when at the bottom it eithier changes level to one before or one after, it will not let you move a sibling to be the last one.

You can make the node last child by dropping it on the parent node. This bothered me for a long time too :)

[chucklepie]

So is this a bug, I'm not sure by the comments, seems like it to me?

btw, sorry for the extra addition, Sometimes sneaking in a question here is the best way to get answers as the UI is sometimes complex to use. In other IDEs when you drag you can move your move your mouse left/right at the relevant points and it indents the control for you. Would be nice.

[YuriSizov]

In the video, TabDemo is selected and visible, switch scene, switch back and it's now at the first. I repeat with multiple and the same happens.

Do you have a tool script that interacts with the tabs, per chance? Can you reproduce this behavior with a simple scene you create from scratch? Also, can you try 3.3.2? I tried to do the same things and it didn't change the visibility or selection no matter what.

[YuriSizov]

The supposed way of switching tabs is changing the Current Tab property of TabContainer I think.

The editor is trying to re-sync the scene with Current Tab.

I wanted to point it out too, but this is not about the tab you see when you run the scene, it's about the editor visibility state. Which for whatever reason gets reset for chucklepie when they switch the scenes, which shouldn't happen.

[timothyqiu]

@pycbouh In a MarginContainer, you can still adjust the margin / size / anchors of child controls in the editor, but these properties will reset when they switch scenes. I think it's the same here for a TabContainer, this container manages visibility instead of margin.

[YuriSizov]

@timothyqiu Except... 🙃

2021-07-27_16-16-55.mp4