Godot 3.2.4 RC5 fails to build on FreeBSD

[nonfatmatt]

Godot version:
1d0929a

OS/device including version:
FreeBSD 13-RC2 / AMD64

Issue description:

Build process seems to hang multiple times on pthreads.

[Initial build] Compiling ==> drivers/gles3/rasterizer_scene_gles3.cpp drivers/unix/thread_posix.cpp: In function 'Error set_name(const String&)': drivers/unix/thread_posix.cpp:53:2: error: 'pthread_set_name_np' was not declared in this scope; did you mean 'pthread_setname_np'? 53 | pthread_set_name_np(running_thread, p_name.utf8().get_data()); | ^~~~~~~~~~~~~~~~~~~ | pthread_setname_np scons: *** [drivers/unix/thread_posix.x11.tools.64.o] Error 1

*Steps to reproduce:
Clone latest Godot 3.2.4 from git. Build with scons -j8 builtin-libvpx=False pulseaudio=False platform=x11

also will fail when adding use_llvm=yes to the command line.

[akien-mga]

I remember fixing this in the past, must have regressed in #45618.

[akien-mga]

Is this error new in 3.2.4 RCs or do you have the same build issue with 3.2.3-stable? Did it work in the past, and if so did you get a FreeBSD system update that could have changed the pthread API?

Last time this code changed was to fix NetBSD support in #42157. My understanding was that both OpenBSD and FreeBSD use pthread_set_name_np:

• https://man.openbsd.org/pthread_set_name_np
• https://www.freebsd.org/cgi/man.cgi?query=pthread_set_name_np&apropos=0&sektion=3&manpath=FreeBSD+13.0-current&arch=default&format=html

[akien-mga]

Right it's #45618 which broke it, @RandomShaper was a bit heavy handed and removed:

#ifdef PTHREAD_BSD_SET_NAME
#include <pthread_np.h>
#endif