Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: VoxelGI and LightmapGI incorrectly calculating the light for the same object #38020

Open
Tracked by #55328
guilhermefelipecgs opened this issue Apr 19, 2020 · 7 comments
Open
Tracked by #55328

Vulkan: VoxelGI and LightmapGI incorrectly calculating the light for the same object #38020

guilhermefelipecgs opened this issue Apr 19, 2020 · 7 comments
Labels
bug confirmed topic:rendering topic:3d
Milestone
4.x

Comments

@guilhermefelipecgs
Copy link
Contributor

guilhermefelipecgs commented Apr 19, 2020 •
edited
Loading

Godot version:
master (495b287)

OS/device including version:
Arch 5.6.4-arch1-1

Issue description:
GIProbe are generating different results depending on the position of the object inside giprobe's cage:
Captura de tela de 2020-04-19 15-48-10
Rotating the object also affects the calc (happens in 3.2.1 as well, maybe is related to #35200):
Captura de tela de 2020-04-19 15-51-00
Captura de tela de 2020-04-19 15-50-43
cube was rotated and rebaked

Steps to reproduce:
I exported a cube with inverted normals from blender.
I setup 3 spot lights for each cube.
Then I bake giprobe with interior on and light intensity to 8.

Minimal reproduction project:
giprobe_test.zip
@guilhermefelipecgs guilhermefelipecgs added this to the 4.0 milestone Apr 19, 2020
@guilhermefelipecgs
Copy link
Contributor Author

CC @clayjohn

@clayjohn
Copy link
Member

Yea that looks like the same issue. I will press reduz about it more, as I still don't understand what is broken and why my PR fixes it.

@guilhermefelipecgs
Copy link
Contributor Author

guilhermefelipecgs commented May 1, 2020 •
edited
Loading

Just a note, BakedLighmap is also affected:
Captura de tela de 2020-05-01 10-34-35

@guilhermefelipecgs guilhermefelipecgs changed the title GIProbe incorrectly calculating the light for the same object GIProbe/BakedLightmap incorrectly calculating the light for the same object May 1, 2020
@Calinou Calinou changed the title GIProbe/BakedLightmap incorrectly calculating the light for the same object Vulkan: VoxelGI and LightmapGI incorrectly calculating the light for the same object Nov 20, 2021
@Calinou Calinou mentioned this issue Nov 25, 2021
Open
@Calinou
Copy link
Member

Calinou commented Dec 17, 2021 •
edited
Loading

@guilhermefelipecgs Can you still reproduce this in the latest master branch with VoxelGI, and with the new GPU lightmapper (LightmapGI)? You can download a nightly build here.

@Calinou

This comment was marked as outdated.

Sign in to view
@Calinou Calinou closed this as completed Feb 6, 2022
@Calinou Calinou removed this from the 4.0 milestone Feb 6, 2022
@guilhermefelipecgs
Copy link
Contributor Author

guilhermefelipecgs commented Feb 6, 2022 •
edited
Loading

The bug is still there (VoxelGI), even worse when entering in orthogonal view now.

Peek.2022-02-06.17-33.mp4

Minimal reproduction project updated to v4.0.alpha1.official giprobe_test.zip

@akien-mga akien-mga reopened this Feb 6, 2022
@akien-mga akien-mga added this to the 4.0 milestone Feb 6, 2022
@guilhermefelipecgs
Copy link
Contributor Author

On the other hand, looks like the LightmapGI has been fixed.

Peek.2022-02-06.17-28.mp4

@Calinou Calinou mentioned this issue Feb 7, 2022
Open
@clayjohn clayjohn modified the milestones: 4.0, 4.x Dec 16, 2022
@bitsawer bitsawer mentioned this issue Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:rendering topic:3d
Projects
None yet
Milestone
4.x
Development

No branches or pull requests
4 participants
@Calinou @guilhermefelipecgs @akien-mga @clayjohn